Add forceWebSockets() and forceLongPolling() #6171

maneesht · 2022-04-21T21:57:52Z

Brought back forceWebSockets API and added forceLongPolling

…t-method

changeset-bot · 2022-04-21T21:57:54Z

🦋 Changeset detected

Latest commit: 2e31c57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/database-compat	Minor
@firebase/database	Minor
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-04-21T22:20:58Z

Size Report ¹

Affected Products

@firebase/app
Type Base (dc0e926) Merge (ba47503) Diff
browser 13.8 kB 13.8 kB +20 B (+0.1%)
esm5 18.0 kB 18.0 kB +20 B (+0.1%)
main 18.9 kB 19.0 kB +49 B (+0.3%)
module 13.8 kB 13.8 kB +20 B (+0.1%)
@firebase/database
Type Base (dc0e926) Merge (ba47503) Diff
browser 247 kB 248 kB +612 B (+0.2%)
esm5 275 kB 276 kB +694 B (+0.3%)
main 280 kB 281 kB +878 B (+0.3%)
module 247 kB 248 kB +612 B (+0.2%)
@firebase/database-compat
Type Base (dc0e926) Merge (ba47503) Diff
browser 17.9 kB 18.0 kB +99 B (+0.6%)
esm5 21.0 kB 21.1 kB +99 B (+0.5%)
main 21.7 kB 21.8 kB +84 B (+0.4%)
module 17.9 kB 18.0 kB +99 B (+0.6%)
@firebase/database-compat/standalone
Type Base (dc0e926) Merge (ba47503) Diff
main 369 kB 370 kB +878 B (+0.2%)
@firebase/firestore
Type Base (dc0e926) Merge (ba47503) Diff
browser 253 kB 253 kB +211 B (+0.1%)
esm5 314 kB 314 kB +202 B (+0.1%)
main 505 kB 506 kB +377 B (+0.1%)
module 253 kB 253 kB +211 B (+0.1%)
react-native 253 kB 253 kB +211 B (+0.1%)

`@firebase/firestore-lite`

Type	Base (`dc0e926`)	Merge (`ba47503`)	Diff
browser	73.3 kB	73.4 kB	+188 B (+0.3%)
esm5	86.7 kB	86.9 kB	+180 B (+0.2%)
main	126 kB	126 kB	+361 B (+0.3%)
module	73.3 kB	73.4 kB	+188 B (+0.3%)
react-native	73.5 kB	73.6 kB	+188 B (+0.3%)

@firebase/functions
Type Base (dc0e926) Merge (ba47503) Diff
browser 9.39 kB 9.39 kB -1 B (-0.0%)
esm5 11.5 kB 11.5 kB -1 B (-0.0%)
main 12.4 kB 12.4 kB -1 B (-0.0%)
module 9.39 kB 9.39 kB -1 B (-0.0%)
@firebase/functions-compat
Type Base (dc0e926) Merge (ba47503) Diff
browser 1.79 kB 1.79 kB -1 B (-0.1%)
esm5 1.98 kB 1.98 kB -1 B (-0.1%)
main 2.34 kB 2.34 kB -1 B (-0.0%)
module 1.79 kB 1.79 kB -1 B (-0.1%)
@firebase/installations
Type Base (dc0e926) Merge (ba47503) Diff
browser 17.8 kB 17.8 kB +13 B (+0.1%)
esm5 22.9 kB 22.9 kB +13 B (+0.1%)
main 23.7 kB 23.8 kB +42 B (+0.2%)
module 17.8 kB 17.8 kB +13 B (+0.1%)
@firebase/messaging
Type Base (dc0e926) Merge (ba47503) Diff
browser 20.8 kB 20.8 kB +25 B (+0.1%)
esm5 26.2 kB 26.2 kB +25 B (+0.1%)
main 26.8 kB 26.9 kB +50 B (+0.2%)
module 20.8 kB 20.8 kB +25 B (+0.1%)
@firebase/messaging-sw
Type Base (dc0e926) Merge (ba47503) Diff
main 29.6 kB 29.6 kB +50 B (+0.2%)
module 22.8 kB 22.9 kB +25 B (+0.1%)
@firebase/util
Type Base (dc0e926) Merge (ba47503) Diff
browser 23.4 kB 20.5 kB -2.87 kB (-12.3%)
esm5 25.5 kB 21.9 kB -3.68 kB (-14.4%)
main 30.6 kB 26.7 kB -3.86 kB (-12.6%)
module 23.4 kB 20.5 kB -2.87 kB (-12.3%)

`bundle`

43 size changes

Type	Base (`dc0e926`)	Merge (`ba47503`)	Diff
analytics (logEvent)	40.0 kB	41.5 kB	+1.50 kB (+3.8%)
app-check (CustomProvider)	33.7 kB	35.2 kB	+1.51 kB (+4.5%)
app-check (ReCaptchaEnterpriseProvider)	35.9 kB	37.4 kB	+1.51 kB (+4.2%)
app-check (ReCaptchaV3Provider)	35.8 kB	37.4 kB	+1.51 kB (+4.2%)
auth (Anonymous)	63.5 kB	65.0 kB	+1.51 kB (+2.4%)
auth (EmailAndPassword)	67.6 kB	69.1 kB	+1.51 kB (+2.2%)
auth (GoogleFBTwitterGitHubPopup)	87.4 kB	88.9 kB	+1.51 kB (+1.7%)
auth (GooglePopup)	87.1 kB	88.6 kB	+1.51 kB (+1.7%)
auth (GoogleRedirect)	87.3 kB	88.8 kB	+1.51 kB (+1.7%)
auth (Phone)	73.6 kB	75.1 kB	+1.51 kB (+2.1%)
database (Append to a list of data)	144 kB	145 kB	+1.67 kB (+1.2%)
database (Filtering data)	142 kB	144 kB	+1.67 kB (+1.2%)
database (Listen for child events)	158 kB	160 kB	+1.67 kB (+1.1%)
database (Listen for value events + Detach listeners)	158 kB	160 kB	+1.67 kB (+1.1%)
database (Listen for value events)	158 kB	160 kB	+1.67 kB (+1.1%)
database (Read data once)	150 kB	152 kB	+1.67 kB (+1.1%)
database (Save data as transactions)	160 kB	162 kB	+1.67 kB (+1.0%)
database (Sort data)	144 kB	146 kB	+1.67 kB (+1.2%)
database (Write data)	143 kB	144 kB	+1.67 kB (+1.2%)
firestore (Persistence)	263 kB	265 kB	+1.50 kB (+0.6%)
firestore (Query Cursors)	203 kB	204 kB	+1.50 kB (+0.7%)
firestore (Query)	204 kB	205 kB	+1.50 kB (+0.7%)
firestore (Read data once)	192 kB	194 kB	+1.50 kB (+0.8%)
firestore (Realtime updates)	195 kB	196 kB	+1.50 kB (+0.8%)
firestore (Transaction)	177 kB	178 kB	+1.72 kB (+1.0%)
firestore (Write data)	176 kB	177 kB	+1.50 kB (+0.9%)
firestore-lite (Query Cursors)	66.3 kB	67.8 kB	+1.50 kB (+2.3%)
firestore-lite (Query)	69.5 kB	71.0 kB	+1.50 kB (+2.2%)
firestore-lite (Read data once)	53.9 kB	55.4 kB	+1.50 kB (+2.8%)
firestore-lite (Transaction)	71.2 kB	72.9 kB	+1.69 kB (+2.4%)
firestore-lite (Write data)	56.6 kB	58.1 kB	+1.50 kB (+2.6%)
functions (call)	27.6 kB	29.1 kB	+1.50 kB (+5.4%)
messaging (send + receive)	43.3 kB	44.7 kB	+1.34 kB (+3.1%)
performance (trace)	47.7 kB	49.2 kB	+1.50 kB (+3.1%)
remote-config (getAndFetch)	42.4 kB	43.9 kB	+1.50 kB (+3.5%)
storage (getBytes)	35.9 kB	37.4 kB	+1.50 kB (+4.2%)
storage (getDownloadURL)	38.0 kB	39.5 kB	+1.50 kB (+3.9%)
storage (getMetadata)	37.5 kB	39.0 kB	+1.50 kB (+4.0%)
storage (list + listAll)	36.9 kB	38.4 kB	+1.50 kB (+4.1%)
storage (updateMetadata)	37.7 kB	39.2 kB	+1.50 kB (+4.0%)
storage (uploadBytes)	42.3 kB	43.8 kB	+1.50 kB (+3.5%)
storage (uploadBytesResumable)	51.7 kB	53.2 kB	+1.50 kB (+2.9%)
storage (uploadString)	42.5 kB	44.0 kB	+1.50 kB (+3.5%)

`firebase`

26 size changes

Type	Base (`dc0e926`)	Merge (`ba47503`)	Diff
firebase-analytics-compat.js	24.3 kB	25.6 kB	+1.26 kB (+5.2%)
firebase-analytics.js	105 kB	111 kB	+5.88 kB (+5.6%)
firebase-app-check.js	90.0 kB	90.0 kB	-4 B (-0.0%)
firebase-app-compat.js	26.4 kB	27.6 kB	+1.26 kB (+4.8%)
firebase-app.js	81.5 kB	87.4 kB	+5.89 kB (+7.2%)
firebase-auth-cordova.js	463 kB	463 kB	-1 B (-0.0%)
firebase-auth-react-native.js	492 kB	487 kB	-4.98 kB (-1.0%)
firebase-auth.js	412 kB	412 kB	-2 B (-0.0%)
firebase-compat.js	780 kB	782 kB	+1.74 kB (+0.2%)
firebase-database-compat.js	165 kB	166 kB	+436 B (+0.3%)
firebase-database.js	603 kB	604 kB	+1.21 kB (+0.2%)
firebase-firestore-compat.js	305 kB	305 kB	+208 B (+0.1%)
firebase-firestore-lite.js	250 kB	251 kB	+840 B (+0.3%)
firebase-firestore.js	824 kB	825 kB	+870 B (+0.1%)
firebase-functions-compat.js	8.12 kB	8.12 kB	-2 B (-0.0%)
firebase-functions.js	32.0 kB	32.0 kB	-3 B (-0.0%)
firebase-messaging-compat.js	36.4 kB	37.5 kB	+1.11 kB (+3.0%)
firebase-messaging-sw.js	101 kB	107 kB	+5.88 kB (+5.8%)
firebase-messaging.js	99.4 kB	105 kB	+5.88 kB (+5.9%)
firebase-performance-compat.js	29.1 kB	30.4 kB	+1.25 kB (+4.3%)
firebase-performance-standalone-compat.es2017.js	86.5 kB	87.1 kB	+623 B (+0.7%)
firebase-performance-standalone-compat.js	64.0 kB	64.9 kB	+922 B (+1.4%)
firebase-performance.js	117 kB	123 kB	+5.88 kB (+5.0%)
firebase-remote-config-compat.js	25.8 kB	27.1 kB	+1.26 kB (+4.9%)
firebase-remote-config.js	106 kB	112 kB	+5.89 kB (+5.5%)
firebase-storage.js	146 kB	146 kB	-1 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/7BwHySKTnX.html

google-oss-bot · 2022-04-21T22:39:34Z

Size Analysis Report ¹

This report is too large (271,437 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ID576QxrMJ.html

…base/firebase-js-sdk into force-rtdb-transport-method

packages/database/src/realtime/TransportManager.ts

hsubox76 · 2022-05-05T01:54:19Z

.changeset/lucky-items-wave.md

+"@firebase/database": patch
+---
+
+Add forceWebSockets() and forceLongPolling()


Can you add backticks to the two methods?

hsubox76 · 2022-05-05T01:54:42Z

.changeset/lucky-items-wave.md

@@ -0,0 +1,6 @@
+---
+"@firebase/database-compat": patch
+"@firebase/database": patch


This is an API change so I think these should both be "minor" bumps.

maneesht added 6 commits April 7, 2022 15:40

Implemented forceWebSockets() and forceLongPolling()

3399b28

Removed xit

8d0526b

Added license

932f309

Merge remote-tracking branch 'origin/master' into force-rtdb-transpor…

83a6f85

…t-method

Included APIs to database-compat

30ad72f

Merge remote-tracking branch 'origin/master' into force-rtdb-transpor…

927560b

…t-method

Removed console log

7b0c2c5

maneesht and others added 6 commits April 21, 2022 15:49

Updated tests

f9bdf59

Fixed formatting

8c1249b

Create lucky-items-wave.md

6b8fce9

Updated tests

1521d5d

Merge branch 'force-rtdb-transport-method' of https://github.com/fire…

6da1223

…base/firebase-js-sdk into force-rtdb-transport-method

Fixed formatting

1a29c85

maneesht marked this pull request as ready for review April 26, 2022 21:59

maneesht requested review from egilmorez, schmidt-sebastian, jsdt, allspain and hsubox76 as code owners April 26, 2022 21:59

jsdt reviewed Apr 26, 2022

View reviewed changes

packages/database/src/realtime/TransportManager.ts Show resolved Hide resolved

maneesht added 5 commits April 26, 2022 15:09

Addresed comments

6b44914

Clarified comment

3d5ba48

Fixed formattign

af11311

Used warning instead of throwing error

1e1ccd3

Fixed formatting

43fb0ce

jsdt approved these changes May 2, 2022

View reviewed changes

hsubox76 reviewed May 5, 2022

View reviewed changes

Addressed comments

2e31c57

hsubox76 approved these changes May 5, 2022

View reviewed changes

maneesht merged commit 9c6808f into master May 5, 2022

maneesht deleted the force-rtdb-transport-method branch May 5, 2022 17:09

google-oss-bot mentioned this pull request May 5, 2022

Version Packages #6235

Merged

hsubox76 mentioned this pull request May 6, 2022

Minor bump for firebase main package #6237

Merged

firebase locked and limited conversation to collaborators Jun 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add forceWebSockets() and forceLongPolling() #6171

Add forceWebSockets() and forceLongPolling() #6171

maneesht commented Apr 21, 2022

changeset-bot bot commented Apr 21, 2022 •

edited

google-oss-bot commented Apr 21, 2022 •

edited

`@firebase/app`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/functions-compat`

`@firebase/installations`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Apr 21, 2022 •

edited

hsubox76 May 5, 2022

hsubox76 May 5, 2022

Add forceWebSockets() and forceLongPolling() #6171

Add forceWebSockets() and forceLongPolling() #6171

Conversation

maneesht commented Apr 21, 2022

changeset-bot bot commented Apr 21, 2022 • edited

🦋 Changeset detected

google-oss-bot commented Apr 21, 2022 • edited

Size Report 1

Affected Products

@firebase/app

@firebase/database

@firebase/database-compat

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/functions-compat

@firebase/installations

@firebase/messaging

@firebase/messaging-sw

@firebase/util

bundle

firebase

Test Logs

google-oss-bot commented Apr 21, 2022 • edited

Size Analysis Report 1

Test Logs

hsubox76 May 5, 2022

Choose a reason for hiding this comment

hsubox76 May 5, 2022

Choose a reason for hiding this comment

changeset-bot bot commented Apr 21, 2022 •

edited

google-oss-bot commented Apr 21, 2022 •

edited

Size Report ¹

`@firebase/app`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/functions-compat`

`@firebase/installations`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Apr 21, 2022 •

edited

Size Analysis Report ¹