Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Fix errors when cookies are disabled in Chrome (compat layer) #5923

Merged
merged 4 commits into from
Jan 24, 2022

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jan 24, 2022

Issue: #5913

This also appears in database, so I won't be closing out the issue with this PR

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2022

🦋 Changeset detected

Latest commit: ce8936e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth-compat Patch
@firebase/auth Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2022

Size Report 1

Affected Products

  • @firebase/auth-compat

    TypeBase (2d04af9)Merge (30b4672)Diff
    browser20.0 kB20.1 kB+83 B (+0.4%)
    esm526.9 kB26.9 kB+87 B (+0.3%)
    main29.4 kB29.5 kB+87 B (+0.3%)
    module20.0 kB20.1 kB+83 B (+0.4%)
  • firebase

    TypeBase (2d04af9)Merge (30b4672)Diff
    firebase-auth-compat.js123 kB123 kB-29 B (-0.0%)
    firebase-compat.js753 kB753 kB-29 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HAR4QTuG5p.html

packages/auth-compat/src/auth.test.ts Show resolved Hide resolved
packages/auth-compat/src/auth.test.ts Show resolved Hide resolved
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2022

@sam-gc sam-gc merged commit 4983f4d into master Jan 24, 2022
@sam-gc sam-gc deleted the sam-gc/more-errors branch January 24, 2022 23:31
@google-oss-bot google-oss-bot mentioned this pull request Jan 26, 2022
@firebase firebase locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants