Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbid prereleasing to npm tag @latest #3927

Merged
merged 3 commits into from Oct 13, 2020
Merged

forbid prereleasing to npm tag @latest #3927

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43c1a58
forbid prereleasing to npm tag latest
Feiyang1 Oct 12, 2020
f00a8b3
add other tags that shouldn't be published to
Feiyang1 Oct 12, 2020
10497d7
remove canary from the forbidden list since it uses the prerelease flow
Feiyang1 Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/release/prerelease.ts
View file
Open in desktop
Expand Up @@ -65,6 +65,12 @@ export async function runPrerelease({
);
}

if (FORBIDDEN_TAGS.includes(npmTag)) {
throw Error(
`Publishing to npm tag ${npmTag} is not allowed for prereleases`
);
}

const sha = await getCurrentSha();
const updates = await getAllPackages();
const pkgJsons = await Promise.all(
Expand Down Expand Up @@ -97,6 +103,8 @@ export async function runPrerelease({
}
}

const FORBIDDEN_TAGS = ['latest', 'next', 'exp'];

interface PrereleaseOptions {
prereleaseName: string;
npmTag: string;
Expand Down