Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AnyJs and Unknown with unknown #1556

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Replace AnyJs and Unknown with unknown #1556

merged 3 commits into from
Feb 22, 2019

Conversation

Feiyang1
Copy link
Member

Replace AnyJs and Unknown with generic unknown introduced in Typescript 3.0

mikelehen
mikelehen approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for tackling.

@mikelehen mikelehen assigned Feiyang1 and unassigned mikelehen Feb 22, 2019
@Feiyang1
Copy link
Member Author

Feiyang1 commented Feb 22, 2019 •
edited

@mikelehen I had to change unknown[] to Array<unknown> to get around tslint, because tslint has not updated to recognize unknown as a simple type.

tslint has made the change but not yet released it. Once the change is released, we can change it back to unknown[].

palantir/tslint#4433

mikelehen
mikelehen approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@Feiyang1 Feiyang1 merged commit 6a0154a into master Feb 22, 2019
@Feiyang1 Feiyang1 deleted the fei-firestore branch February 22, 2019 22:55
@Feiyang1 Feiyang1 mentioned this pull request Mar 8, 2019
Merged
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Feiyang1 @mikelehen