Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox CI issue #6833

Merged
merged 7 commits into from Nov 29, 2022
Merged

Fix Firefox CI issue #6833

merged 7 commits into from Nov 29, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Nov 28, 2022

Github's latest image for ubuntu is ubuntu-22.04 which seems to come with a version of Firefox that causes the karma launcher to hang and eventually give up when trying to launch Firefox. Other users have reported the Firefox bin isn't there at all, which is not exactly the same issue, but could be related. Locking it to ubuntu-20.04 until we can figure out why (hopefully it isn't that current and future versions of Firefox don't work with karma-firefox-launcher).

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2022

⚠️ No Changeset found

Latest commit: 7a03687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2022

@hsubox76 hsubox76 marked this pull request as ready for review November 28, 2022 22:08
@hsubox76 hsubox76 changed the title Test Firefox CI issue Fix Firefox CI issue Nov 28, 2022
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 243e47d into master Nov 29, 2022
@hsubox76 hsubox76 deleted the ch-firestore-test branch November 29, 2022 20:04
@dconeybe dconeybe mentioned this pull request Nov 29, 2022
7 tasks
@dconeybe
Copy link
Contributor

Thansk @hsubox76!

levino pushed a commit to levino/firebase-js-sdk that referenced this pull request Dec 10, 2022
@firebase firebase locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants