Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused 'messaging-types' #6750

Merged
merged 2 commits into from Nov 3, 2022
Merged

Remove Unused 'messaging-types' #6750

merged 2 commits into from Nov 3, 2022

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Nov 2, 2022

Currently only types in @messaging & @messaging-interop-types are used by the main and compact package.

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022 •
edited

⚠️ No Changeset found

Latest commit: ec241f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zwu52 zwu52 requested a review from hsubox76 November 2, 2022 17:07
hsubox76
hsubox76 reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also delete the line in CODEOWNERS?
packages/messaging-types @zwu52 @firebase/jssdk-global-approvers

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 2, 2022 •
edited

Size Report 1

Affected Products

No changes between base commit (9e9ee7b) and merge commit (0bd2cd4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/T3nYW15L4p.html

@zwu52 zwu52 requested a review from hsubox76 November 2, 2022 17:36
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 2, 2022 •
edited

Size Analysis Report 1

Affected Products

No changes between base commit (9e9ee7b) and merge commit (0bd2cd4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KMhWzCKEPR.html

@github-actions github-actions bot added the doc-changes PRs that affect docs label Nov 2, 2022
hsubox76
hsubox76 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zwu52 zwu52 merged commit 7e08670 into master Nov 3, 2022
@zwu52 zwu52 deleted the delete_messaging_type branch November 3, 2022 17:19
@firebase firebase locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@egilmorez egilmorez

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zwu52 @google-oss-bot @hsubox76 @egilmorez