Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbid prereleasing to npm tag @latest #3927

Merged
merged 3 commits into from Oct 13, 2020
Merged

forbid prereleasing to npm tag @latest #3927

merged 3 commits into from Oct 13, 2020

Conversation

Feiyang1
Copy link
Member

prevent accidentally releasing prereleases to firebase@latest

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2020 •
edited

⚠️ No Changeset found

Latest commit: 10497d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

hsubox76
hsubox76 approved these changes Oct 12, 2020
View reviewed changes
scripts/release/prerelease.ts Outdated
@@ -97,6 +103,8 @@ export async function runPrerelease({
}
}

const FORBIDDEN_TAGS = ['latest'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add "next", "exp", and/or "canary"? They're not as important but, I mean, since the code is all set up, why not?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2020 •
edited

Binary Size Report

Affected SDKs

No changes between base commit (3c420b0) and head commit (0eeee5d).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2020 •
edited

Size Analysis Report

Affected Products

No changes between base commit (3c420b0) and head commit (0eeee5d).

Test Logs

@Feiyang1 Feiyang1 merged commit df27732 into master Oct 13, 2020
@Feiyang1 Feiyang1 deleted the fei-prerelease-restrict branch October 13, 2020 04:10
@firebase firebase locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Feiyang1 @google-oss-bot @hsubox76