Revert "Check DOMException error name instead of error message"

This reverts commit 7437de8.
firebase · Apr 17, 2024 · d838690 · d838690
1 parent be96f50
commit d838690
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 21 deletions.
diff --git a/packages/auth/src/core/strategies/passkey.test.ts b/packages/auth/src/core/strategies/passkey.test.ts
@@ -96,12 +96,7 @@ describe('passkey', async () => {
     }
     sinon
       .stub(navigator.credentials, 'get')
-      .throws(
-        new DOMException(
-          'The operation either timed out or was not allowed.',
-          'NotAllowedError'
-        )
-      );
+      .throws(new Error('The operation either timed out or was not allowed.'));
 
     sinon.stub(navigator.credentials, 'create').resolves(mockCredential);
 
@@ -171,12 +166,7 @@ describe('passkey', async () => {
     }
     sinon
       .stub(navigator.credentials, 'get')
-      .throws(
-        new DOMException(
-          'The operation either timed out or was not allowed.',
-          'NotAllowedError'
-        )
-      );
+      .throws(new Error('The operation either timed out or was not allowed.'));
 
     mockEndpoint(Endpoint.START_PASSKEY_SIGNIN, {
       credentialRequestOptions: {
@@ -253,12 +243,7 @@ describe('passkey', async () => {
     }
     sinon
       .stub(navigator.credentials, 'create')
-      .throws(
-        new DOMException(
-          'The operation either timed out or was not allowed.',
-          'NotAllowedError'
-        )
-      );
+      .throws(new Error('The operation either timed out or was not allowed.'));
 
     mockEndpoint(Endpoint.START_PASSKEY_ENROLLMENT, {
       credentialCreationOptions: {

diff --git a/packages/auth/src/core/strategies/passkey.ts b/packages/auth/src/core/strategies/passkey.ts
@@ -42,7 +42,8 @@ import { UserCredentialImpl } from '../user/user_credential_impl';
 import { signInAnonymously } from './anonymous';
 
 const DEFAULT_PASSKEY_ACCOUNT_NAME = 'Unnamed account (Web)';
-const PASSKEY_LOOK_UP_ERROR_NAME = 'NotAllowedError';
+const PASSKEY_LOOK_UP_ERROR_MESSAGE =
+  'The operation either timed out or was not allowed.';
 
 /**
  * Signs in a user with a passkey. Use enrollPasskey to enroll a passkey credential for the current user.
@@ -93,8 +94,7 @@ export async function signInWithPasskey(
     return userCredential;
   } catch (error) {
     if (
-      error instanceof DOMException &&
-      error.name === PASSKEY_LOOK_UP_ERROR_NAME &&
+      (error as Error).message.includes(PASSKEY_LOOK_UP_ERROR_MESSAGE) &&
       !manualSignUp
     ) {
       // If the user is not signed up, sign them up anonymously