Improve testIgnoresTargetMappingAfterExistenceFilterMismatch (#5880)

firebase · Jan 11, 2022 · d0c8bfe · d0c8bfe
1 parent c271d16
commit d0c8bfe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/firestore/test/unit/local/local_store.test.ts b/packages/firestore/test/unit/local/local_store.test.ts
@@ -1936,7 +1936,9 @@ function genericLocalStoreTests(
           .toContainTargetData(target, 10, 10, byteStringFromString('foo'))
           // Create an existence filter mismatch and verify that the last limbo
           // free snapshot version is deleted
-          .after(existenceFilterEvent(targetId, 2, 20))
+          .after(
+            existenceFilterEvent(targetId, documentKeySet(key('foo/a')), 2, 20)
+          )
           .after(noChangeEvent(targetId, 20))
           .toContainTargetData(target, 0, 0, ByteString.EMPTY_BYTE_STRING)
           // Re-run the query as a collection scan

diff --git a/packages/firestore/test/util/helpers.ts b/packages/firestore/test/util/helpers.ts
@@ -356,16 +356,17 @@ export function noChangeEvent(
 
 export function existenceFilterEvent(
   targetId: number,
-  count: number,
+  syncedKeys: DocumentKeySet,
+  remoteCount: number,
   snapshotVersion: number
 ): RemoteEvent {
   const aggregator = new WatchChangeAggregator({
-    getRemoteKeysForTarget: () => documentKeySet(),
+    getRemoteKeysForTarget: () => syncedKeys,
     getTargetDataForTarget: targetId =>
       targetData(targetId, TargetPurpose.Listen, 'foo')
   });
   aggregator.handleExistenceFilter(
-    new ExistenceFilterChange(targetId, new ExistenceFilter(count))
+    new ExistenceFilterChange(targetId, new ExistenceFilter(remoteCount))
   );
   return aggregator.createRemoteEvent(version(snapshotVersion));
 }