Skip to content

Commit

Permalink
Verify OIDC/SAML sign in against Auth Emulator (#5776)
Browse files Browse the repository at this point in the history
* Add TODO for unused custom parameters
* Uncommented logic for sign in with SAML providers

Corresponding internal bug: b/192387796
  • Loading branch information
lisajian committed Dec 2, 2021
1 parent dc6b447 commit bdc71d1
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions packages/auth/demo/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import {
verifyPasswordResetCode,
getMultiFactorResolver,
OAuthProvider,
SAMLAuthProvider,
GoogleAuthProvider,
FacebookAuthProvider,
TwitterAuthProvider,
Expand Down Expand Up @@ -1188,6 +1189,7 @@ function onPopupRedirectAddCustomParam(_event) {
e.preventDefault();
});
// Append constructed row to parameter list container.
// TODO: These parameters need to be passed into OAuth calls with provider.setCustomParameters()
$('#popup-redirect-custom-parameters').append($node);
}

Expand All @@ -1204,10 +1206,13 @@ function onPopupRedirectGenericProviderClick() {
* Performs the corresponding popup/redirect action for a SAML provider.
*/
function onPopupRedirectSamlProviderClick() {
alertNotImplemented();
// var providerId = $('#popup-redirect-saml-providerid').val();
// var provider = new SAMLAuthProvider(providerId);
// signInWithPopupRedirect(provider);
if (!USE_AUTH_EMULATOR) {
alertNotImplemented();
return;
}
var providerId = $('#popup-redirect-saml-providerid').val();
var provider = new SAMLAuthProvider(providerId);
signInWithPopupRedirect(provider);
}

/**
Expand Down

0 comments on commit bdc71d1

Please sign in to comment.