Skip to content

Commit

Permalink
Use closure-net as a dependency of Firestore (#8190)
Browse files Browse the repository at this point in the history
* Add closure library blobs as Firestore dependency.

* Remove our compilation of Closure.

* Add closure-net as a git submodule.

* remove temporary .only in test.

* prettier.

* add yarn.lock differences.

* create a types.d.ts for the webchannel-wrapper package.

* Bring back the aggregated types and implementations for size report.

* Undo CI changes for git submodules.

* Remove the git submodule.

* Use git+https in package.json devDependencies.

* prettier.

* Set up rollup for webchannel-wrapper (#8203)

* convert webchannel-wrapper package to use rollup

* clean up rollup config

* formatting

* Create thick-spoons-check.md

* Better changeset.

* Address feedback on versioning.

---------

Co-authored-by: Christina Holland <chholland@google.com>
  • Loading branch information
ehsannas and hsubox76 committed May 1, 2024
1 parent 7709f10 commit 4b49630
Show file tree
Hide file tree
Showing 18 changed files with 147 additions and 668 deletions.
6 changes: 6 additions & 0 deletions .changeset/thick-spoons-check.md
@@ -0,0 +1,6 @@
---
"@firebase/firestore": patch
"@firebase/webchannel-wrapper": major
---

Use closure-net as a dependency of webchannel-wrapper and Firestore.
Empty file added .gitmodules
Empty file.
3 changes: 2 additions & 1 deletion packages/firestore/externs.json
Expand Up @@ -24,7 +24,8 @@
"packages/component/dist/src/provider.d.ts",
"packages/component/dist/src/component_container.d.ts",
"packages/logger/dist/src/logger.d.ts",
"packages/webchannel-wrapper/src/index.d.ts",
"packages/webchannel-wrapper/dist/bloom-blob/bloom_blob_types.d.ts",
"packages/webchannel-wrapper/dist/webchannel-blob/webchannel_blob_types.d.ts",
"packages/util/dist/src/crypt.d.ts",
"packages/util/dist/src/defaults.d.ts",
"packages/util/dist/src/emulator.d.ts",
Expand Down
Expand Up @@ -27,9 +27,9 @@ import {
EventTarget,
StatEvent,
Event,
Stat,
FetchXmlHttpFactory
} from '@firebase/webchannel-wrapper';
FetchXmlHttpFactory,
Stat
} from '@firebase/webchannel-wrapper/webchannel-blob';

import { Token } from '../../api/credentials';
import { ExperimentalLongPollingOptions } from '../../api/long_polling_options';
Expand Down
3 changes: 2 additions & 1 deletion packages/firestore/src/remote/bloom_filter.ts
Expand Up @@ -14,7 +14,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Md5, Integer } from '@firebase/webchannel-wrapper';

import { Md5, Integer } from '@firebase/webchannel-wrapper/bloom-blob';

import { newTextEncoder } from '../platform/text_serializer';

Expand Down
Expand Up @@ -19,7 +19,7 @@
// These tests are mostly to ensure that the exported classes correctly map to
// underlying functionality from google-closure-library.

import { Md5, Integer } from '@firebase/webchannel-wrapper';
import { Md5, Integer } from '@firebase/webchannel-wrapper/bloom-blob';
import { expect } from 'chai';

import { newTextEncoder } from '../../../src/platform/text_serializer';
Expand Down
9 changes: 9 additions & 0 deletions packages/webchannel-wrapper/bloom-blob/package.json
@@ -0,0 +1,9 @@
{
"name": "@firebase/webchannel-wrapper/bloom-blob",
"description": "Bloom filter related code from the Closure library.",
"main": "../dist/bloom-blob/bloom_blob_es2018.js",
"browser": "../dist/bloom-blob/esm/bloom_blob_es2018.js",
"module": "../dist/bloom-blob/esm/bloom_blob_es2018.js",
"esm5": "../dist/bloom-blob/bloom_blob_es5.js",
"typings": "../dist/bloom-blob/bloom_blob_types.d.ts"
}
@@ -1,6 +1,6 @@
/**
* @license
* Copyright 2020 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -15,5 +15,10 @@
* limitations under the License.
*/

/** @type {!Object} */
const module = {};
/**
* This package has no main entry point and only allows imports from its
* two subpaths. This file is provided for the top-level package.json
* "main" field to point to.
*/

export default {};
86 changes: 0 additions & 86 deletions packages/webchannel-wrapper/externs/overrides.js

This file was deleted.

218 changes: 0 additions & 218 deletions packages/webchannel-wrapper/gulpfile.js

This file was deleted.

0 comments on commit 4b49630

Please sign in to comment.