Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Add .ruby-version file for GHA #9921

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[Infra] Add .ruby-version file for GHA #9921

merged 1 commit into from
Jun 17, 2022

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 17, 2022

Context

- uses: ruby/setup-ruby@v1
      with:
        ruby-version: '3.0' # Not needed with a .ruby-version file

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 June 17, 2022 21:24
@ncooke3
Copy link
Member Author

ncooke3 commented Jun 17, 2022

@paulb777, after some experiments in #9919, I think the .ruby-version file needs to be checked into master to be picked up by GHA. It should be possible based on actions/setup-ruby#31 (comment)

Can I try merging this PR so I can then confirm that setting the ruby-version in each YML file isn't needed anymore?

@ncooke3 ncooke3 merged commit 82483b6 into master Jun 17, 2022
@ncooke3 ncooke3 deleted the nc/ruby-gha branch June 17, 2022 21:37
@ncooke3
Copy link
Member Author

ncooke3 commented Jun 17, 2022

Cool, this did the trick. Verified here: https://github.com/firebase/firebase-ios-sdk/runs/6943204414?check_suite_focus=true#step:4:14

@ryanwilson
Copy link
Member

As a heads up: this broke my local CocoaPods flow since I had version 2.7.1 installed and not 2.7.0:

$ pod repo update
rbenv: version `ruby-2.7' is not installed (set by <REDACTED_PATH_TO_REPO>/.ruby-version)

I'm not sure the best solution, but wanted to call it out in case others run into this.

@ncooke3
Copy link
Member Author

ncooke3 commented Jul 12, 2022

Sorry @ryanwilson, I had a feeling something like that would happen! Were you able to easily pin your version to 2.7.0?

@ryanwilson
Copy link
Member

Sorry @ryanwilson, I had a feeling something like that would happen! Were you able to easily pin your version to 2.7.0?

It was easier for me to just change that value to my local version (2.7.1) 😝

@firebase firebase locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants