Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Carthage distribution for 8.0.0 #8087

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented May 16, 2021

This PR is the resulting build distribution from the fixes in #8084

Fix #7039
Fix #7576

Will publish the Carthage update when #8084 and this PR are approved.

Testing:
Unzipped the archive from https://github.com/firebase/firebase-ios-sdk/actions/runs/845683211

Edited the json files in a local directory:

Screen Shot 2021-05-15 at 5 57 09 PM

Edited the sample in Carthage.md like

Screen Shot 2021-05-15 at 6 14 40 PM

Verified carthage update succeeded.

@google-oss-bot
Copy link

google-oss-bot commented May 16, 2021

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from 68.78% (4f00074) to 68.77% (73911aa) by -0.01%.

    Filename Base (4f00074) Head (73911aa) Diff
    FIRAuthKeychainServices.m 60.16% 59.38% -0.78%
  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from 60.91% (4f00074) to 75.57% (73911aa) by +14.66%.

    Filename Base (4f00074) Head (73911aa) Diff
    FDLUtilities.m 73.48% 90.15% +16.67%
    FIRDLDefaultRetrievalProcessV2.m 14.06% 72.92% +58.85%
    FIRDLJavaScriptExecutor.m 26.28% 82.48% +56.20%
    FIRDynamicLinkNetworking.m 44.44% 80.83% +36.39%

Test Logs

@paulb777 paulb777 requested a review from ryanwilson May 17, 2021 14:04
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs are 404ing for me at the moment - changes look good otherwise outside of a question about MLModelDownloader + zip/binary availability

@paulb777
Copy link
Member Author

They're 404'ing because not yet published since waiting for reviews.

If we once excluded MLModelDownloader, it's no longer happening since it's already part of the 8.0.0 zip distro.

@paulb777
Copy link
Member Author

8.0.0 is now distributed via Carthage

@paulb777 paulb777 merged commit f920f2f into master May 17, 2021
@paulb777 paulb777 deleted the pb-carthage-update-800 branch May 17, 2021 19:44
@firebase firebase locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.