Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post merge integration tests #1552

Merged
merged 1 commit into from Apr 13, 2024
Merged

Fix post merge integration tests #1552

merged 1 commit into from Apr 13, 2024

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Apr 12, 2024 •
edited

inlined
inlined approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did the new typescript version give us?

@colerogers
Copy link
Contributor Author

@inlined The post-merge tests were failing with Error: node_modules/@types/node/events.d.ts(102,43): error TS2370: A rest parameter must be of an array type., bumping the version to match with our package version, fixed the issue - https://github.com/firebase/firebase-functions/actions/runs/8666919656/job/23768771827

@colerogers colerogers merged commit 909215f into master Apr 13, 2024
13 checks passed
@colerogers colerogers deleted the colerogers.fix-postmerge-int-tests branch April 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@Berlioz Berlioz Awaiting requested review from Berlioz

@blidd-google blidd-google Awaiting requested review from blidd-google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colerogers @inlined