Support consumeAppCheckToken option for callable functions #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weixifan
reviewed
Apr 13, 2023
src/common/providers/https.ts
Outdated
| appCheckData = await getAppCheck(getApp()).verifyToken(appCheck); | ||
| const appCheck = getAppCheck(getApp()); | ||
| if (options.consumeAppCheckToken) { | ||
| if (appCheck.verifyToken.length === 1) { |
There was a problem hiding this comment.
I might be wrong here but if appCheck.verifyToken is undefined, accessing .length throws, doesn't it?
Would it be better to do the following instead?
if (typeof appCheck.verifyToken === "function") {
There was a problem hiding this comment.
I just realized that you are checking the number of parameters here. If we are confident that the Admin SDK used always has the appCheck API, please ignore my comment above.
There was a problem hiding this comment.
Think defensive coding is better here!
lahirumaramba
approved these changes
May 2, 2023
taeold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.