Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate documentation for in-app feedback #1294

Merged
merged 2 commits into from Nov 1, 2022
Merged

Reinstate documentation for in-app feedback #1294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef978b
Revert "Hide documentation for in-app feedback (#1245)"
kaibolay Oct 31, 2022
d348601
Merge branch 'master' into revert-1245-kaibolay/hide-in-app-feedback-…
kaibolay Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/v2/providers/alerts/appDistribution.ts
View file
Open in desktop
Expand Up @@ -52,8 +52,6 @@ export interface NewTesterDevicePayload {
/**
* The internal payload object for receiving in-app feedback from a tester.
* Payload is wrapped inside a `FirebaseAlertData` object.
*
* @alpha
*/
export interface InAppFeedbackPayload {
["@type"]: "type.googleapis.com/google.events.firebase.firebasealerts.v1.AppDistroInAppFeedbackPayload";
Expand Down Expand Up @@ -262,8 +260,6 @@ export function onNewTesterIosDevicePublished(
* Declares a function that can handle receiving new in-app feedback from a tester.
* @param handler - Event handler which is run every time new feedback is received.
* @returns A function that you can export and deploy.
*
* @alpha
*/
export function onInAppFeedbackPublished(
handler: (event: AppDistributionEvent<InAppFeedbackPayload>) => any | Promise<any>
Expand All @@ -274,8 +270,6 @@ export function onInAppFeedbackPublished(
* @param appId - A specific application the handler will trigger on.
* @param handler - Event handler which is run every time new feedback is received.
* @returns A function that you can export and deploy.
*
* @alpha
*/
export function onInAppFeedbackPublished(
appId: string,
Expand All @@ -287,8 +281,6 @@ export function onInAppFeedbackPublished(
* @param opts - Options that can be set on the function.
* @param handler - Event handler which is run every time new feedback is received.
* @returns A function that you can export and deploy.
*
* @alpha
*/
export function onInAppFeedbackPublished(
opts: AppDistributionOptions,
Expand All @@ -300,8 +292,6 @@ export function onInAppFeedbackPublished(
* @param appIdOrOptsOrHandler - A specific application, options, or an event-handling function.
* @param handler - Event handler which is run every time new feedback is received.
* @returns A function that you can export and deploy.
*
* @alpha
*/
export function onInAppFeedbackPublished(
appIdOrOptsOrHandler:
Expand Down