Fix bug where function configuration with null couldn't be deployed. (#…

…1246)
firebase · Sep 29, 2022 · cc6e28e · cc6e28e
1 parent cf27ac6
commit cc6e28e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1 +1,2 @@
 - Fix reference docs for performance monitoring.
+- Fix bug where function configuration wil null values couldn't be deployed. (#1246)
diff --git a/spec/runtime/manifest.spec.ts b/spec/runtime/manifest.spec.ts
@@ -7,6 +7,36 @@ describe('stackToWire', () => {
     params.clearParams();
   });
 
+  it('converts stack with null values values', () => {
+    const stack: ManifestStack = {
+      endpoints: {
+        v2http: {
+          platform: 'gcfv2',
+          entryPoint: 'v2http',
+          labels: {},
+          httpsTrigger: {},
+          maxInstances: null,
+        },
+      },
+      requiredAPIs: [],
+      specVersion: 'v1alpha1',
+    };
+    const expected = {
+      endpoints: {
+        v2http: {
+          platform: 'gcfv2',
+          entryPoint: 'v2http',
+          labels: {},
+          httpsTrigger: {},
+          maxInstances: null,
+        },
+      },
+      requiredAPIs: [],
+      specVersion: 'v1alpha1',
+    };
+    expect(stackToWire(stack)).to.deep.equal(expected);
+  });
+
   it('converts Expression types in endpoint options to CEL', () => {
     const intParam = params.defineInt('foo', { default: 11 });
     const stringParam = params.defineString('bar', {

diff --git a/src/runtime/manifest.ts b/src/runtime/manifest.ts
@@ -107,7 +107,7 @@ export function stackToWire(stack: ManifestStack): Object {
     for (const [key, val] of Object.entries(obj)) {
       if (val instanceof Expression) {
         obj[key] = val.toCEL();
-      } else if (typeof val === 'object') {
+      } else if (typeof val === 'object' && val !== null) {
         traverse(val);
       }
     }