docs(readme): tag realtime db + add firestore db #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for the database point to the realtime database. There doesn't seem to be any mention of Firestore in the docs, but looking in the source code, it exists and just passes it through to the `@google-cloud/firestore` package.
hiranya911
suggested changes
May 7, 2020
| @@ -67,7 +67,8 @@ environments. | |||
| ## Documentation | |||
|
|
|||
| * [Setup Guide](https://firebase.google.com/docs/admin/setup/) | |||
| * [Database Guide](https://firebase.google.com/docs/database/admin/start/) | |||
| * [Realtime Database Guide](https://firebase.google.com/docs/database/admin/start/) | |||
| * [Firestore Guide](https://googleapis.dev/nodejs/firestore/latest/index.html) | |||
There was a problem hiding this comment.
I think this should point to https://firebase.google.com/docs/firestore
There was a problem hiding this comment.
The reason that I submitted this pr was because I was trying to get started with coding and the api for this library is different to the api used on the main docs. The PR is editable if you want to change the url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for the database point to the realtime database. There doesn't seem to be any mention of Firestore in the docs, but looking in the source code, it exists and just passes it through to the
@google-cloud/firestorepackage.