Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate credentials to use google-auth-library #2466

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: Migrate credentials to use google-auth-library #2466

wants to merge 3 commits into from
+367 −379

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Feb 21, 2024 •
edited

  • Migrate Application default credentials, Service account credentials, Refresh token credentials, and Compute engine credentials to use google-auth-library

Resolves: #1377

This was referenced Feb 28, 2024
Open
Open
jonathanedey
jonathanedey reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Left one comment.

src/app/credential-internal.ts
);
return {
...credentials,
access_token: accessToken,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to assign access_token here?

@lahirumaramba lahirumaramba self-assigned this Feb 29, 2024
@andrewmbenton andrewmbenton mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanedey jonathanedey jonathanedey left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Allow credential file type "external_account" when calling admin.credential.applicationDefault()
3 participants
@lahirumaramba @hsubox76 @jonathanedey