passkey config admin changes #2326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthecheung
approved these changes
Oct 19, 2023
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
|
what is the plan for integration tests? |
|
@Xiaoshouzi-gh integration tests have been drafted in this PR. Waiting on backend to allow this. |
| @@ -69,4 +72,13 @@ export class Auth extends BaseAuth { | |||
| public projectConfigManager(): ProjectConfigManager { | |||
| return this.projectConfigManager_; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the passkey config manager instance. | |||
There was a problem hiding this comment.
can you update this api reference? looks redundant.
src/auth/passkey-config.ts
Outdated
| ); | ||
| } | ||
| // Validation for updating an existing PasskeyConfig. | ||
| if (!isCreateRequest && typeof rpId !== 'undefined') { |
There was a problem hiding this comment.
do you allow customer to pass in the existing value rpId for updates?
There was a problem hiding this comment.
Doesn't that seem a little redundant? Since we can't change rpId once created?
* user record changes for getAccountInfo() * lint and api-extractor fixes * Apply suggestions from code review Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com> * remove `[key: string]: unknown;` field from `PasskeyInfoResponse` * add undefined displayName case * name and credentialId are not optional * add `rpId` to update --------- Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.