Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating custom claims in updateUser() #1882

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

brettwillis
Copy link

@brettwillis brettwillis commented Aug 22, 2022

Closes #1876

Summary

Currently, the custome user claims can be updated with setCustomUserClaims(), and the user details can be updated with updateUser(). Both use same /accounts:update REST API under the hood.

This allows account and claims info to be updated in one hit using the updateUser() method.

@brettwillis brettwillis marked this pull request as ready for review October 24, 2022 18:06
@brettwillis
Copy link
Author

@lahirumaramba any thoughts on this?

@brettwillis
Copy link
Author

@lahirumaramba @prameshj I completed the test suite adding integration tests and unit tests. All relevant tests that were applied to setCustomUserClaims() are applied to the relevant claims functionality in updateUser(). Would appreciate a moment to review 🙏🏼 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Auth: Update user details and custom claims in the same request
1 participant