docs(firestore-bigquery-export): clarify meaning of "exclude old data" #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original description is generically worded. This additional specificity should make it clear to Firestore users what is meant by "old data".
|
Hi there! thanks for contributing! The README.md isn't actually directly edited, what you need to do is find the corresponding documentation in the extension.yaml or the PREINSTALL.md and amend it there, before running Can you do this and push changes, and I'll review? |
cabljac
changed the title
|
@cabljac change made as per your direction. Thanks! |
cabljac
force-pushed
the
next
branch
3 times, most recently
from
c8885bd
to
d1481a2
Compare
|
Hi @gregfenton, the README is still missing, could you please |
|
Is there a document describing how to make docs PRs in a "clean way" ? I'd prefer to get it right on the first pass, and not bother busy people like y'all 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original description is generically worded. This additional specificity should make it clear to Firestore users what is meant by "old data".