Move core query builder logic out to @finos/legend-query-builder and cleanup Jest test idiomatic usages
#1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6639410 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
+ Coverage 40.57% 41.18% +0.61%
==========================================
Files 1230 1227 -3
Lines 54259 54182 -77
Branches 12283 12264 -19
==========================================
+ Hits 22013 22315 +302
+ Misses 32169 31782 -387
- Partials 77 85 +8
|
akphi
requested review from
pierredebelen and
MauricioUyaguari
as code owners
akphi
changed the title
@finos/legend-query-builder and cleanup Jest test idiomatic usages
MauricioUyaguari
approved these changes
Sep 14, 2022
MauricioUyaguari
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.mockResolvedValue(...)to.mockReturnValue(Promise.resolve(...)): Strangely, this has to do withJest.mockResolvedValue(...)not creating the samePromiseasNode.Promise, for contexts, see:[Bug]: "mockImplementation" is behaving different than the syntacical-sugar version"mockResolvedValue" jestjs/jest#13206
mockResolvedValue / mockRejectedValue should returns a real Promise jestjs/jest#6645
Jest globals differ from Node globals jestjs/jest#2549
Evaluate node core modules within a
vm.Contextnodejs/node#31852MOBX__enableSpyOrMock, andMOBX__disableSpyOrMock: these were seemingly only useful against the bugs: Mobx 6.1 breaks spying on actions in unit test mobxjs/mobx#2752 when we were doingflow(... some arrow function...)pattern, now we have moved to usemakeObservable, things seem fine. See the note for these here:meta::pure::functions::date::Timeandmeta::pure::functions::date::Durationto core systemDndProvidertoLegendApplicationComponentFrameworkProvider@finos/legend-extension-application-studio-management-toolkit- make sure to document this somewhere@finos/legend-application-queryto@finos/legend-query-builder:@finos/legend-extension-application-studio-query-builderpluginHow did you test this change?