Fix a bug in SourceInformation.isValid (#808)

finos · May 14, 2024 · f7e8fbc · f7e8fbc
1 parent 892706c
commit f7e8fbc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...legend-pure-m4/src/main/java/org/finos/legend/pure/m4/coreinstance/SourceInformation.java b/...legend-pure-m4/src/main/java/org/finos/legend/pure/m4/coreinstance/SourceInformation.java
@@ -273,6 +273,8 @@ public boolean isValid()
         return (this.sourceId != null) &&
                 (this.startLine >= 1) &&
                 (this.startColumn >= 1) &&
+                (this.column >= 1) &&
+                (this.endColumn >= 1) &&
                 isNotBefore(this.line, this.column, this.startLine, this.startColumn) &&
                 isNotBefore(this.endLine, this.endColumn, this.line, this.column);
     }

diff --git a/...nd-pure-m4/src/test/java/org/finos/legend/pure/m4/coreinstance/TestSourceInformation.java b/...nd-pure-m4/src/test/java/org/finos/legend/pure/m4/coreinstance/TestSourceInformation.java
@@ -321,6 +321,10 @@ public void testIsValid()
         Assert.assertFalse(new SourceInformation(sourceId, 5, 1, 5, 3, 5, 2).isValid());
         Assert.assertFalse(new SourceInformation(sourceId, 5, 3, 5, 2, 5, 8).isValid());
         Assert.assertFalse(new SourceInformation(sourceId, 5, 3, 5, 5, 4, 8).isValid());
+
+        Assert.assertTrue(new SourceInformation(sourceId, 5, 3, 6, 1, 7, 8).isValid());
+        Assert.assertFalse(new SourceInformation(sourceId, 5, 3, 6, 0, 7, 8).isValid());
+        Assert.assertFalse(new SourceInformation(sourceId, 5, 3, 6, 1, 7, 0).isValid());
     }
 
     private void assertSubsumes(SourceInformation sourceInfo1, SourceInformation sourceInfo2)