Updates to handle string-building taint with invokedynamic concatenation in JDK > 8 #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2023 16:14
…long and double. The long and double primitive type parameters occupy two stack registers so we check the locations of stack parameters that can modify taint status. Any reference types as well as primitive char will propagate taint to the resulting String. Do not add a mutable stack index to the TaintMethodConfig because we don't have a mutable object on the stack in the case of the invokedynamic call.
In order to test invokedynamic string concatenation handling, we need to build some sample code with a later JDK so use Java 11 for the compiler target in a new build submodule. We cannot currently switch the existing findsecbugs-samples-java to Java 11 without breaking tests, and a new module is added just for the Java 11 classes we want to test. Added setter for FindSecBugsGlobalConfig.workaroundVisitInvokeDynamic that the unit test uses.
jbindel
changed the title
h3xstream
approved these changes
Jan 9, 2024
|
To enable handling of Java 9+ string concatenation, we have to set the system property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #690 adds handling of JDK > 8 string concatenation with invokedynamic and
makeConcatWithConstants. There are some cases it does not handle such as concat of long or double values. This pull request address the parameter offsets affected by long and double, which take two spots on the stack.It also fixes issues where taint on a stack object is modified when we do not want that.
In order to test this change, we need some sample classes built with a JDK > 8, and using JDK11 on the current
findsecbugs-samples-javaintroduces errors in the unit tests so there is a build submodule that builds specific classes to a JDK 11 target.