fix(highlight): #747 Add line offset to highlight line #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrismJS sort of broken backward compatibility, while trying to improve highlight resilience[^1]. Since then it is required to add `data-line-offset` for any code, which doesn't start counting from 1, which is pretty each time, we deal with stack frames. This commits add silently required data attribute in HTML, bringing back highlight feature and recovering from some fall through errors, raised by `TypeError` in JS execution flow (i.e. switching application and full frames tabs). [^1]: PrismJS/prism@9a4e725 Signed-off-by: Bart Jaskulski <bjaskulski@protonmail.com>
|
Actually, offset attribute has started to be required since this commit: PrismJS/prism@098e300 |
|
Thank you! |
|
Released in 2.15.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrismJS sort of broken backward compatibility, while trying to improve highlight resilience1. Since then it is required to add
data-line-offsetfor any code, which doesn't start counting from 1, which is pretty each time, we deal with stack frames.This commits add silently required data attribute in HTML, bringing back highlight feature and recovering from some fall through errors, raised by
TypeErrorin JS execution flow (i.e. switching application and full frames tabs).Footnotes
https://github.com/PrismJS/prism/commit/9a4e725b76d22759fec58e1929450bbfe1bb6661 ↩