Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that call to a member function getFrameFilters() on null #751

Merged
merged 1 commit into from Mar 6, 2023
Merged

Fix the bug that call to a member function getFrameFilters() on null #751

merged 1 commit into from Mar 6, 2023

Conversation

huangdijia
Copy link
Contributor

@huangdijia huangdijia commented Mar 4, 2023 •
edited

whoops/src/Whoops/Handler/PrettyPageHandler.php

Line 307 in 3e8aebb

$frames = $this->getInspector()->getFrames($this->getRun()->getFrameFilters());

@huangdijia huangdijia mentioned this pull request Mar 4, 2023
Merged
@limingxinleo

This comment was marked as duplicate.

Sign in to view
@AmraniCh
Copy link
Contributor

AmraniCh commented Mar 5, 2023

You're right, If we need to call a Whoops handler we have to set Its Run instance explicitly.

@AmraniCh
Copy link
Contributor

AmraniCh commented Mar 5, 2023

@denis-sokolov

This was referenced Mar 5, 2023
Closed
Closed
@denis-sokolov denis-sokolov merged commit e864ac9 into filp:master Mar 6, 2023
@denis-sokolov
Copy link
Collaborator

Included in 2.15.1.

@StrykeSlammerII StrykeSlammerII mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huangdijia @limingxinleo @AmraniCh @denis-sokolov