Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add previous exception messages to plain text output #609

Merged
merged 2 commits into from Jun 21, 2019
Merged

add previous exception messages to plain text output #609

merged 2 commits into from Jun 21, 2019

Commits on Dec 3, 2018

  1. add previous exception messages to plain text output 

    Can be disabled via `PlainTextHandler::addPreviousToOutput(false)` and
adds lines between the exception and the trace containing the exception
and line of creator.

The method `Inspector::getFrames()` already appends all frames from the
previous exceptions. So there is no need in adding the trace for each
previous exception.

IMO the test tests something that it should not test: the output of the
line number. But that should be in a separate PR. I've at least added
constants for the line numbers so that you only have to change them once
for all tests.
    @tflori
    tflori committed Dec 3, 2018
    Copy the full SHA
    88b9298 View commit details
    Browse the repository at this point in the history

  2. suggested changes for previous output in plaintext handler

    @tflori
    tflori committed Dec 3, 2018
    Copy the full SHA
    54bf2df View commit details
    Browse the repository at this point in the history