suggested changes for previous output in plaintext handler

filp · Dec 3, 2018 · bce5c5f · bce5c5f
1 parent 88b9298
commit bce5c5f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Whoops/Handler/PlainTextHandler.php b/src/Whoops/Handler/PlainTextHandler.php
@@ -176,7 +176,7 @@ public function generateResponse()
         if ($this->addPreviousToOutput) {
             $previous = $exception->getPrevious();
             while ($previous) {
-                $message .= "\nBefore: " . $this->getExceptionOutput($previous);
+                $message .= "\n\nCaused by\n" . $this->getExceptionOutput($previous);
                 $previous = $previous->getPrevious();
             }
         }
@@ -313,7 +313,7 @@ private function getTraceOutput()
      * @param \Throwable $exception
      * @return string
      */
-    protected function getExceptionOutput($exception)
+    private function getExceptionOutput($exception)
     {
         return sprintf(
             "%s: %s in file %s on line %d",

diff --git a/tests/Whoops/Handler/PlainTextHandlerTest.php b/tests/Whoops/Handler/PlainTextHandlerTest.php
@@ -267,7 +267,7 @@ public function testReturnsWithPreviousExceptions()
                 'Outer exception message',
                 __FILE__,
                 258,
-                'Before: ' . RuntimeException::class,
+                "\nCaused by\n" . RuntimeException::class,
                 'Inner exception message',
                 __FILE__,
                 258