update lassie v0.8.1 #324
Merged
update lassie v0.8.1 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanzo
approved these changes
Apr 7, 2023
lidel
reviewed
Apr 7, 2023
| } | ||
| if (key === "depth" && val === "0") { | ||
| newKey = "car-scope"; | ||
| newVal = "root"; |
There was a problem hiding this comment.
@hannahhoward is this a typo or did we implement different things? 🙈
ipfs/bifrost-gateway#80 → https://github.com/ipfs/bifrost-gateway/pull/81/files → I did block instead of root as we used both during discussion, and I went with block as it felt more descriptive (just like file is more than adl).
(not the end of the world, no need to revert release, bifrost-gateway still sends depth=0 so it will work fine, but we should clean this up next week before we remove depth)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Update Lassie to support car-scope parameter, a few other things
For discussion
The conversion of depth parameter to car-scope in lassie.js is cause I think ARC may still be sending only depth=1