fix(time): Use chrono for offset #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrono has fixed its vulnerability since v4.2.0 Fix filecoin-project#17 Signed-off-by: paulip1792 <paulip1792@outlook.com>
vmx
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Thanks for the PR. I'd like to wait until emabee/flexi_logger#120 is resolved as until then. One could potentially be still be vulnerable to RUSTSEC-2020-0159, if a Cargo.lock could still point to v0.4.19 of chrono.
vmx
added a commit
that referenced
this pull request
Oct 10, 2022
Due to https://rustsec.org/advisories/RUSTSEC-2020-0159, it wasn't possible to get the local time in multi-threaded contexts. This was fixed with the latest release v0.24 of `flexi_logger`. It is using a fixed version of `chrono`, which also means that we don't have a dependency on `time` anymore. Closed #18.
vmx
added a commit
that referenced
this pull request
Oct 10, 2022
Due to https://rustsec.org/advisories/RUSTSEC-2020-0159, it wasn't possible to get the local time in multi-threaded contexts. This was fixed with the latest release v0.24 of `flexi_logger`. It is using a fixed version of `chrono`, which also means that we don't have a dependency on `time` anymore. Closes #18.
vmx
added a commit
that referenced
this pull request
Oct 10, 2022
Due to https://rustsec.org/advisories/RUSTSEC-2020-0159, it wasn't possible to get the local time in multi-threaded contexts. This was fixed with the latest release v0.24 of `flexi_logger`. It is using a fixed version of `chrono`, which also means that we don't have a dependency on `time` anymore. Closes #17, #18.
vmx
added a commit
that referenced
this pull request
Oct 10, 2022
Due to https://rustsec.org/advisories/RUSTSEC-2020-0159, it wasn't possible to get the local time in multi-threaded contexts. This was fixed with the latest release v0.24 of `flexi_logger`. It is using a fixed version of `chrono`, which also means that we don't have a dependency on `time` anymore. Fixes #17. Closes #18.
|
@paulip1792 I've opened #19 with a fix. |
vmx
added a commit
that referenced
this pull request
Oct 10, 2022
Due to https://rustsec.org/advisories/RUSTSEC-2020-0159, it wasn't possible to get the local time in multi-threaded contexts. This was fixed with the latest release v0.24 of `flexi_logger`. It is using a fixed version of `chrono`, which also means that we don't have a dependency on `time` anymore. Fixes #17. Closes #18.
|
@paulip1792 I've merged my PR into master. As you also provided a PR. Do you have a way to test the current master branch out if it works as expected? That would be appreciated. |
|
@vmx It works fine as expected. |
|
@paulip1792 Thanks for testing, I've released it as 0.1.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chronohas fixed its vulnerability since v4.2.0Fix #17