Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] feat: Maximum stack size accounting #561

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[wip] feat: Maximum stack size accounting #561

wants to merge 3 commits into from

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 15, 2022

Depends on filecoin-project/fvm-wasm-instrument#5

TBD if we want to keep this, it's probably useful for debugging; If we want this, we will need to:

  • Put this behind a feature flag
  • Use updated wasm-instrument

@magik6k magik6k force-pushed the fix/native-stack-limits branch 5 times, most recently from 8f5fa91 to 1ad79bf Compare May 15, 2022 22:08
Base automatically changed from fix/native-stack-limits to master May 15, 2022 22:52
raulk
raulk reviewed May 16, 2022
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magik6k If I understand correctly, this is the instrumentation we use to identify the length of the Wasm stacks in existing code, right? If so, I agree that this should be behind a feature flag, and it's not necessary for M1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magik6k @raulk