Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop indirectly depending on deprecated github.com/prometheus/common #7473

Merged

Conversation

ribasushi
Copy link
Contributor

Gets us out of prometheus/common#306

@ribasushi ribasushi marked this pull request as ready for review October 7, 2021 16:32
@ribasushi ribasushi requested a review from a team as a code owner October 7, 2021 16:32
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #7473 (2c10dc6) into master (1993efe) will decrease coverage by 2.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7473      +/-   ##
==========================================
- Coverage   39.21%   37.05%   -2.17%     
==========================================
  Files         631      631              
  Lines       66787    66787              
==========================================
- Hits        26191    24745    -1446     
- Misses      36024    37715    +1691     
+ Partials     4572     4327     -245     
Impacted Files Coverage Δ
itests/kit/control.go 0.00% <0.00%> (-100.00%) ⬇️
gateway/handler.go 0.00% <0.00%> (-91.31%) ⬇️
itests/kit/client.go 0.00% <0.00%> (-87.02%) ⬇️
api/wrap.go 0.00% <0.00%> (-79.32%) ⬇️
itests/kit/deals_state.go 0.00% <0.00%> (-71.43%) ⬇️
chain/stmgr/rpc/rpcstatemanager.go 0.00% <0.00%> (-57.90%) ⬇️
itests/kit/ensemble_opts_nv.go 46.15% <0.00%> (-53.85%) ⬇️
cli/paych.go 0.00% <0.00%> (-49.68%) ⬇️
extern/storage-sealing/terminate_batch.go 18.62% <0.00%> (-41.67%) ⬇️
cli/helper.go 0.00% <0.00%> (-40.00%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1993efe...2c10dc6. Read the comment docs.

@ribasushi
Copy link
Contributor Author

@whyrusleeping this is why you can't upgrade Estuary

@jennijuju we need to backport this to 1.13.0, it's really annoying to build with the API otherwise.

@magik6k magik6k merged commit 4e98f0a into master Oct 7, 2021
@magik6k magik6k deleted the chore/bump-prometheus-export-get-out-of-deprecated-deploop branch October 7, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants