Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI tools for the DAGStore inverted index #7361

Merged

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Sep 21, 2021

This PR is adding 2 CLI tools to the DAGStore inverted index:

  • Lookup the pieces that a CID belongs to
  • Inspecting the size of the inverted index

It is not ready for merging, because we first need to:

TODO:

  • rename inverted index to piece index so it is easier for users to understand what this is about.

@dirkmc dirkmc force-pushed the feat/cid-to-piece-idx branch 2 times, most recently from 2792fe1 to 588d6ec Compare November 12, 2021 08:43
@nonsense nonsense force-pushed the nonsense/dagstore-inverted-index-cli-custom branch from f5cb358 to f3ff008 Compare November 12, 2021 11:39
@nonsense nonsense force-pushed the nonsense/dagstore-inverted-index-cli-custom branch 2 times, most recently from fc53a75 to 80b8b0e Compare November 17, 2021 11:34
@nonsense nonsense force-pushed the nonsense/dagstore-inverted-index-cli-custom branch from 80b8b0e to e11872d Compare November 17, 2021 13:00
cmd/lotus-miner/dagstore.go Outdated Show resolved Hide resolved
cmd/lotus-miner/dagstore.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #7361 (37dda67) into feat/cid-to-piece-idx (a4fd3de) will decrease coverage by 3.61%.
The diff coverage is 26.50%.

❗ Current head 37dda67 differs from pull request most recent head 992942a. Consider uploading reports for the commit 992942a to get more accurate results
Impacted file tree graph

@@                    Coverage Diff                    @@
##           feat/cid-to-piece-idx    #7361      +/-   ##
=========================================================
- Coverage                  43.36%   39.74%   -3.62%     
=========================================================
  Files                        482      635     +153     
  Lines                      50078    67445   +17367     
=========================================================
+ Hits                       21716    26809    +5093     
- Misses                     24411    36016   +11605     
- Partials                    3951     4620     +669     
Impacted Files Coverage Δ
api/api_storage.go 0.00% <ø> (ø)
node/impl/storminer.go 25.74% <0.00%> (+10.55%) ⬆️
cmd/lotus-miner/dagstore.go 19.42% <40.74%> (ø)
miner/miner.go 51.65% <0.00%> (-3.32%) ⬇️
extern/sector-storage/stores/local.go 57.30% <0.00%> (-0.57%) ⬇️
storage/wdpost_changehandler.go 98.11% <0.00%> (ø)
cmd/lotus-sim/list.go 0.00% <0.00%> (ø)
cmd/lotus-shed/bitfield.go 0.00% <0.00%> (ø)
cmd/lotus-miner/actor.go 7.92% <0.00%> (ø)
cmd/lotus-sim/simulation/blockbuilder/errors.go 0.00% <0.00%> (ø)
... and 300 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fd3de...992942a. Read the comment docs.

@nonsense nonsense marked this pull request as ready for review November 17, 2021 13:39
@nonsense nonsense requested a review from a team as a code owner November 17, 2021 13:39
@nonsense nonsense merged commit 5454aeb into feat/cid-to-piece-idx Nov 17, 2021
@nonsense nonsense deleted the nonsense/dagstore-inverted-index-cli-custom branch November 17, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants