Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop messages from prior rounds that can't affect the protocol outcome. #207

Merged
merged 1 commit into from May 14, 2024
Merged

Drop messages from prior rounds that can't affect the protocol outcome. #207

merged 1 commit into from May 14, 2024

Conversation

anorth
Copy link
Member

@anorth anorth commented May 9, 2024

Closes #205

@anorth anorth requested review from Kubuxu and ranchalp May 9, 2024 23:39
Stebalien
Stebalien approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(modulo test fixes)

This seems like a good way to avoid storing cruft. We should also consider dropping state from previous rounds.

@Stebalien
Copy link
Member

We should also consider dropping state from previous rounds.

I see we've already discussed this and your point about it not being worth it is fair.

@anorth anorth enabled auto-merge May 14, 2024 01:29
@anorth anorth added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 530d54f May 14, 2024
3 checks passed
@anorth anorth deleted the anorth/drop-old branch May 14, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@ranchalp ranchalp ranchalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop messages from past rounds (except COMMIT)
4 participants
@anorth @Stebalien @Kubuxu @ranchalp