Implement storage power evolution in simulations for honest participants #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/sim-pt-evolution
branch
3 times, most recently
from
7c2b84d
to
925d258
Compare
|
Could you change this PR base to #184 so it's easier to review the diff proposed here? |
anorth
reviewed
May 9, 2024
| sim *Simulation | ||
| id gpbft.ActorID | ||
| sim *Simulation | ||
| pubkey gpbft.PubKey |
There was a problem hiding this comment.
The power table plumbing is external to the sim, as F3 won't know for which participants it will be signing. Only the application itself knows that.
| }) | ||
| }) | ||
| } | ||
| } |
masih
force-pushed
the
masih/sim-pt-evolution
branch
from
925d258
to
e9599cb
Compare
Implement the ability to evolve the storage power across honest participants over the course of a simulation. The changes introduce primitives to allow doing this and reflect the changes across the tests using a uniformed fixed storage power generator. The adversary storage power evolution is not yet implemented and left to future work in favour of reducing the number of lines changed. Add two tests that exercise increase and decrease of storage power over sync and async message passing: 1. Sudden increase of storage power results in the corresponding group of nodes to dominate consensus as expected. 2. Gradual decrease of storage power results in loss of dominance among the corresponding group. Fixes #114
masih
force-pushed
the
masih/sim-pt-evolution
branch
from
e9599cb
to
c729b87
Compare
Kubuxu
approved these changes
May 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the ability to evolve the storage power across honest participants over the course of a simulation. The changes introduce primitives to allow doing this and reflect the changes across the tests using a uniformed fixed storage power generator.
The adversary storage power evolution is not yet implemented and left to future work in favour of reducing the number of lines changed.
Add two tests that exercise increase and decrease of storage power over sync and async message passing:
Sudden increase of storage power results in the corresponding group of nodes to dominate consensus as expected.
Gradual decrease of storage power results in loss of dominance among the corresponding group.
Fixes #114
Rebased on top of #187; review that first.