Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update anyhow to 1.0.65 #716

Merged
merged 1 commit into from Sep 28, 2022
Merged

Update anyhow to 1.0.65 #716

merged 1 commit into from Sep 28, 2022

Conversation

anorth
Copy link
Member

@anorth anorth commented Sep 27, 2022

See dtolnay/anyhow#271

This was causing build problems when pulling in github.com/helix-collective/filecoin crates, which use thiserror.

@anorth anorth enabled auto-merge (squash) September 27, 2022 18:50
@codecov-commenter
Copy link

Codecov Report

Merging #716 (4b0ee74) into master (fc3c24b) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   84.32%   84.23%   -0.09%     
==========================================
  Files          89       89              
  Lines       18215    18215              
==========================================
- Hits        15360    15344      -16     
- Misses       2855     2871      +16     
Impacted Files Coverage Δ
actors/miner/src/deadline_info.rs 79.77% <0.00%> (-16.86%) ⬇️
actors/init/src/lib.rs 96.77% <0.00%> (-1.62%) ⬇️
runtime/src/util/message_accumulator.rs 93.63% <0.00%> (-0.91%) ⬇️
test_vm/src/lib.rs 88.10% <0.00%> (-0.12%) ⬇️
actors/market/src/lib.rs 81.64% <0.00%> (+0.09%) ⬆️
actors/cron/src/lib.rs 93.10% <0.00%> (+3.44%) ⬆️

Copy link
Collaborator

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is just updating it in the lock file, and not the individual toml files the correct thing to do here (I'm not sure).

@anorth
Copy link
Member Author

anorth commented Sep 27, 2022

Good point. I ran cargo update -p anyhow at @Stebalien's suggestion, but have now updated all the explicit deps.

Copy link
Collaborator

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is what I would expect, I'm happy to approve.

@anorth anorth merged commit d5056d5 into master Sep 28, 2022
@anorth anorth deleted the anorth/anyhow branch September 28, 2022 19:03
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants