Index Provider integration #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
changed the base branch from
main
to
nonsense/legacy-cli-commands
aarshkshah1992
changed the title
aarshkshah1992
changed the title
dirkmc
reviewed
Mar 8, 2022
| } | ||
| } | ||
|
|
||
| func (w *Wrapper) IndexerAnnounceAllDeals(ctx context.Context) error { |
There was a problem hiding this comment.
Would it make sense for this method to announce all Boost and legacy markets deals?
There was a problem hiding this comment.
We can do it or we can do it as we're currently doing it. I don't have a strong preference.
There was a problem hiding this comment.
Where possible I'd prefer to keep knowledge of the two different data sources inside the wrapper, rather than leaking it into the CLI layer
There was a problem hiding this comment.
Man, moving all that markets code here (which has intimate knowledge of various market states and what they mean) will add mantainence burden here and is something I'd like to avoid if possible. Remember, the plan is to eventually deprecate markets.
dirkmc
approved these changes
Mar 9, 2022
|
Subsumbed by #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be able to announce indices and serve indices for Boost deals and legacy markets deals.
Markets PR at filecoin-project/go-fil-markets#691.
TODO
AnnounceAllDealsCLI on Sofia Miner.