Enable EIP-155 transactions as part of FIP-0091 #1003
Merged
+78
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth,
raulk,
jsoares and
TippyFlitsUK
as code owners
aarshkshah1992
changed the title
aarshkshah1992
changed the title
TippyFlitsUK
approved these changes
May 9, 2024
| @@ -9,12 +9,12 @@ category: Core | |||
| created: 2024-04-17 | |||
| --- | |||
|
|
|||
| # FIP-00XX: Add support for legacy Homestead Ethereum Transactions | |||
| # FIP-0091: Add support for Homstead and EIP-155 Ethereum Transactions ("legacy" Ethereum transactions) | |||
|
|
|||
| ## Simple Summary | |||
There was a problem hiding this comment.
@aarshkshah1992 just want to check before I make the change everywhere- I believe you are referencing EIP1155, not EIP155. I don't believe the latter exists. Yes?
There was a problem hiding this comment.
EIP155 exists and is correct (and linked in the original PR) -- it introduces chain_id as part of the tx.
EIP1155 doesn't exist, it's actually an ERC number.
There was a problem hiding this comment.
@kaitlin-beegle Hey yes as Jorge pointed out above, EIP-155 can be found at https://eips.ethereum.org/EIPS/eip-155.
Comment on lines
+62
to
+64
| To ensure compatibility with Filecoin's signature verification, which only recognizes `V` values of 0 or 1 (as is also the case with the current signature verification implementation in `go-ethereum`), adjustments will be made to the `V` parameter in legacy transactions before verifying their signatures. Specifically, for Homestead transactions, 27 will be subtracted from the `V` parameter. For EIP-155 transactions, the adjustment will involve subtracting (2*ChainID + 35) from the `V` parameter. | ||
|
|
||
| This adjustment is necessary because, unlike EIP-1559 transactions supported by Filecoin that strictly use `V` values of 0 or 1, the `V` parameter in Homestead transactions can be either 27 or 28, and for EIP-155 transactions, it is calculated as (0 or 1 + (2 * ChainID + 35)) where the selection of 0 or 1 is the same as in EIP-1599 transactions. |
There was a problem hiding this comment.
Suggested change
| To ensure compatibility with Filecoin's signature verification, which only recognizes `V` values of 0 or 1 (as is also the case with the current signature verification implementation in `go-ethereum`), adjustments will be made to the `V` parameter in legacy transactions before verifying their signatures. Specifically, for Homestead transactions, 27 will be subtracted from the `V` parameter. For EIP-155 transactions, the adjustment will involve subtracting (2*ChainID + 35) from the `V` parameter. | |
| This adjustment is necessary because, unlike EIP-1559 transactions supported by Filecoin that strictly use `V` values of 0 or 1, the `V` parameter in Homestead transactions can be either 27 or 28, and for EIP-155 transactions, it is calculated as (0 or 1 + (2 * ChainID + 35)) where the selection of 0 or 1 is the same as in EIP-1599 transactions. | |
| To ensure compatibility with Filecoin's signature verification, which only recognizes `V` values of 0 or 1 (as is also the case with the current signature verification implementation in `go-ethereum`), adjustments will be made to the `V` parameter in legacy transactions before verifying their signatures. | |
| For Homestead transactions, the 'V' parameter will be calculated as _V_-27. This is because Homestead transactions are coded as either 27 or 28. | |
| For EIP-155 transactions, the adjustment will involve subtracting (2*ChainID + 35) from the `V` parameter. This is because it is calculated as (0 or 1 + (2 * ChainID + 35)) where the selection of 0 or 1 is the same as in EIP-1599 transactions. |
There was a problem hiding this comment.
I think the original more descriptive language will help flush out better the change that needs to be made here.
jsoares
approved these changes
May 9, 2024
Co-authored-by: Kaitlin Beegle <46908964+kaitlin-beegle@users.noreply.github.com> Co-authored-by: TippyFlits <james@filoz.org>
rvagg
reviewed
May 13, 2024
rvagg
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates FIP-0091 to also enable support for EIP-155 transactions so that Coinbase Wallet , Trust Wallet etc can submit EIP-155 EVM transactions to Filecoin.
https://eips.ethereum.org/EIPS/eip-155