Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform: Prevent Destroy Resource #383

Open
wants to merge 15 commits into
base: figma
Choose a base branch
from
Open

Terraform: Prevent Destroy Resource #383

wants to merge 15 commits into from

Conversation

DavidMah
Copy link

@DavidMah DavidMah commented Jan 31, 2022 •
edited

Implements a golang version of https://github.com/figma/figma/blob/master/config/terraform/modules/asserts/prevent-destroy/main.tf. Test is documented in the accompanying PR on the figma repo: https://github.com/figma/figma/pull/57614

dmahfigma and others added 15 commits January 4, 2022 13:59
@dmahfigma @maxbfigma
Custom aws_ecs_task_set resource
63dad0d 
Originally from this commit, but tweaked for compatibility with v3.64.2

  commit 5522751
  Author: Kumarappan-A <kumarappan@zenefits.com>
  Date:   Mon May 20 23:36:26 2019 -0700

      resource/aws_ecs_task_set: Support ECS task set

      (cherry picked from commit 9dc5c3a)
@dmahfigma @maxbfigma
ListenerRule: Do not replace for priority tweaks (#296)
6e39390
@dmahfigma @maxbfigma
Don't set network_configuration property on services with EXTERNAL de…
126e626 
…ployment controller
@dmahfigma @maxbfigma
Automate releases to figma/aws on terraform registry
17e6db4
@dmahfigma @maxbfigma
Update go.sum from running go build
fa85115
@maxbfigma
Delete "Lock Threads" github action
ebbc3ea 
We inherited a Github action from upstream that tries to lock discussion
threads on a schedule. Because our repo doesn't have access to do this
on the public repo, it fails and sends me an email once a day. This
removes this action, because we don't need it.
@dmahfigma
prevent-destroy
2aa847d
@dmahfigma
autosave [dmah/prevent-destroy Mon Jan 31 16:05:03 PST 2022]
819f6f4
@dmahfigma
fix
c673f1d
@dmahfigma
gofmt
160780c
@dmahfigma
revert go.sum
eacf539
@dmahfigma
gofmt
e6a314a
@dmahfigma
go mod tidy
8b072a5
@dmahfigma
comment
4834132
@dmahfigma
revert this again?
0e9cb72
@DavidMah DavidMah requested a review from a team February 1, 2022 01:02
@DavidMah DavidMah marked this pull request as ready for review February 1, 2022 01:02
@DavidMah
Copy link
Author

DavidMah commented Feb 1, 2022 •
edited

Red build

  • one seems to be an infra failure
  • another seems to fail no matter what, even on a brand new branch that doesn't do anything. Doing go mod tidy like it says doesn't do anything. Added to the documentation on the notion page
  • another one is a lint failure on tests for a different module that i didn't touch with this PR

ianvonseggern1
ianvonseggern1 approved these changes Feb 1, 2022
View reviewed changes
Copy link

@ianvonseggern1 ianvonseggern1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!! I did not realize how clean this would be, very cool

@DavidMah
Copy link
Author

DavidMah commented Feb 1, 2022

fyi cc @maxbfigma @jfirebaugh @bereket42 , being other terraform interested people

@Slava Slava force-pushed the figma branch 2 times, most recently from ebe4e2d to 129458b Compare February 7, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianvonseggern1 ianvonseggern1 ianvonseggern1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@DavidMah @ianvonseggern1 @dmahfigma @maxbfigma