Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2235 - PostgreSQL: data type of Date parameters can't always be resolved #2242

Open
wants to merge 12 commits into
base: Issue-#2213
Choose a base branch
from
Open

Issue #2235 - PostgreSQL: data type of Date parameters can't always be resolved #2242

wants to merge 12 commits into from

Conversation

homedirectory
Copy link
Contributor

Resolve #2235

Summary of changes:

  • Convert all java.sql.Timestamp values retrieved from DB to java.util.Date
  • Hibernate type mapping for Date values has been used only for retrieving values from a DB,
    now it's also used for binding query parameters (PostgreSQL only).
  • Added tests:
    • Application of EQL's isNull() to Date values
    • Persistence/retrieval of UTC datetime properties across different timezones

@homedirectory
#2235 Test persistence/retrieval of UTC datetime properties across di…
4177b6b 
…fferent timezones
@homedirectory
#2235 PostgreSQL: use explicit cast for Date operands of IS NULL
5ac7a15
@homedirectory
#2235 Test usage of Date with EQL's isNull()
03effd4
@homedirectory
#2235 Convert all java.sql.Timestamp values retrieved from DB to java…
e866e46 
….util.Date
@homedirectory
#2235 Hibernate datetime type: wrap Date as LocalDateTime during para…
e152b96 
…meter binding

Required to make PostgreSQL recognise such values as SQL TIMESTAMP type.
@homedirectory
#2235 Register our custom datetime type with Hibernate
24c1bf5
@homedirectory
#2235 Refactor UtcDateTimeType and DateTimeType using a single abstra…
6611ba1 
…ction

This abstraction facilitates definition of datetime types relative to
arbitrary time zones.
@homedirectory
Revert "#2235 PostgreSQL: use explicit cast for Date operands of IS N…
af9ef09 
…ULL"

This reverts commit 5ac7a15.
@homedirectory
#2235 Test yielding of Date as properties of UtcDateTimeType and Date…
56f87df 
…TimeType
@homedirectory
#2235 Minor code style improvements
0fc677a
@homedirectory
#2235 Enable registration of DateTimeType with Hibernate only for Pos…
153e2fe 
…tgreSQL
@homedirectory homedirectory requested a review from 01es April 22, 2024 09:15
@homedirectory homedirectory changed the base branch from develop to Issue-#2213 April 25, 2024 08:03
@homedirectory
Revert "#2235 Enable registration of DateTimeType with Hibernate only…
0573d67 
… for PostgreSQL"

This reverts commit 153e2fe.

The additional complexity of having a separate type mapping mechanism is
unnecessary. SQL Server has proved to work correctly with this type
mapping enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@01es 01es Awaiting requested review from 01es

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PostgreSQL: data type of Date parameters can't always be resolved
1 participant
@homedirectory