-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash per method packages #299
Remove lodash per method packages #299
Conversation
Could not find any use of lodash debounce in the project.
Use of lodash "per method packages" are now discouraged, and the recommended solution is to import the whole lodash package. @see https://lodash.com/per-method-packages
🦋 Changeset detectedLatest commit: edd3243 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use direct import to make sure only the needed method will be imported. Co-authored-by: Dmytro <dschewchenko@users.noreply.github.com>
@nclavaud Error: Cannot find module '/home/runner/work/vite-plugin-checker/vite-plugin-checker/packages/vite-plugin-checker/node_modules/lodash/pick' imported from /home/runner/work/vite-plugin-checker/vite-plugin-checker/packages/vite-plugin-checker/dist/esm/main.js in tests Something is wrong there is seems |
Co-authored-by: Danila Rodichkin <daniluk4000@outlook.com>
Thanks for the great work. Sorry for the delayed response due to a long period of burn out. It will be released in the next patch version soon. |
Sorry for tagging you @fi3ework ! We appreciate the work you do 🧡 |
fixes #297
lodash.debounce
(I could not find any use of this package)lodash.pick
in favor oflodash
(see https://lodash.com/per-method-packages)