Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash per method packages #299

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

nclavaud
Copy link
Contributor

@nclavaud nclavaud commented Jan 25, 2024

fixes #297

Could not find any use of lodash debounce in the project.
Use of lodash "per method packages" are now discouraged, and the
recommended solution is to import the whole lodash package.

@see https://lodash.com/per-method-packages
Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: edd3243

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-checker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit edd3243
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/65b92bb2bcffb50008835a25
😎 Deploy Preview https://deploy-preview-299--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Use direct import to make sure only the needed method will be imported.

Co-authored-by: Dmytro <dschewchenko@users.noreply.github.com>
@daniluk4000
Copy link
Contributor

@nclavaud Error: Cannot find module '/home/runner/work/vite-plugin-checker/vite-plugin-checker/packages/vite-plugin-checker/node_modules/lodash/pick' imported from /home/runner/work/vite-plugin-checker/vite-plugin-checker/packages/vite-plugin-checker/dist/esm/main.js in tests

Something is wrong there is seems

Co-authored-by: Danila Rodichkin <daniluk4000@outlook.com>
@fi3ework fi3ework merged commit bc4fa05 into fi3ework:main Jan 30, 2024
9 checks passed
@fi3ework
Copy link
Owner

Thanks for the great work. Sorry for the delayed response due to a long period of burn out. It will be released in the next patch version soon.

@nclavaud nclavaud mentioned this pull request Jan 31, 2024
@Kegulf
Copy link

Kegulf commented Feb 2, 2024

Sorry for tagging you @fi3ework !
This plugin is very good, and we didn't want to stop using it.

We appreciate the work you do 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub reports a CVE because of lodash.pick in this plugin
9 participants