Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eslint flat config #282

Merged
merged 6 commits into from
Jan 31, 2024
Merged

feat: support eslint flat config #282

merged 6 commits into from
Jan 31, 2024

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Oct 16, 2023

fix #244

Before this PR is merged, you can try it through ni -D @hyoban/vite-plugin-checker

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

🦋 Changeset detected

Latest commit: b32c2e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-checker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit b32c2e5
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/65b9e41eab881500081b42b5
😎 Deploy Preview https://deploy-preview-282--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@17359898647
Copy link

I used your bag. That didn't solve the problem

@hyoban
Copy link
Contributor Author

hyoban commented Oct 19, 2023

@17359898647 You need to enable it via useFlatConfig option

@17359898647
Copy link

@17359898647 You need to enable it via useFlatConfig option

thanks

@zhoushengdong
Copy link

@hyoban Thank you, it worked!

@felixranesberger
Copy link

Thanks for the pull request 🎉
Is there any update on the merge status @fi3ework?

Copy link
Owner

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the docs for this field in docs/checkers/eslint.md and update changesets with a patch version (as we still haven't reach 1.0.0). Then we can go and merge it. Thanks!

@hyoban hyoban requested a review from fi3ework January 31, 2024 06:24
@fi3ework fi3ework merged commit c5d5109 into fi3ework:main Jan 31, 2024
8 of 9 checks passed
@fi3ework
Copy link
Owner

Sorry for the delayed response due to a long period of burn out. Thanks for this great work again!

fi3ework added a commit that referenced this pull request Jan 31, 2024
fi3ework added a commit that referenced this pull request Jan 31, 2024
fi3ework added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint doesn't work with flat config
5 participants