fix: use virtual: for virtual module (#236)

fi3ework · May 7, 2023 · ec4366d · ec4366d
1 parent 400ecde
commit ec4366d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/eight-swans-give.md b/.changeset/eight-swans-give.md
@@ -0,0 +1,5 @@
+---
+"vite-plugin-checker": patch
+---
+
+use `virtual:` for virtual module
diff --git a/packages/vite-plugin-checker/src/client/index.ts b/packages/vite-plugin-checker/src/client/index.ts
@@ -5,6 +5,8 @@ const _require = createRequire(import.meta.url)
 export const RUNTIME_CLIENT_RUNTIME_PATH = '/@vite-plugin-checker-runtime'
 export const RUNTIME_CLIENT_ENTRY_PATH = '/@vite-plugin-checker-runtime-entry'
 
+export const wrapVirtualPrefix = (id: `/${string}`): `virtual:${string}` =>
+  `virtual:${id.slice('/'.length)}`
 export const composePreambleCode = (base = '/', config: Record<string, any>) => `
 import { inject } from "${base}${RUNTIME_CLIENT_RUNTIME_PATH.slice(1)}";
 inject({

diff --git a/packages/vite-plugin-checker/src/main.ts b/packages/vite-plugin-checker/src/main.ts
@@ -9,6 +9,7 @@ import {
   RUNTIME_CLIENT_ENTRY_PATH,
   RUNTIME_CLIENT_RUNTIME_PATH,
   runtimeCode,
+  wrapVirtualPrefix,
   WS_CHECKER_RECONNECT_EVENT,
 } from './client/index.js'
 import {
@@ -114,17 +115,17 @@ export function checker(userConfig: UserPluginConfig): Plugin {
     },
     resolveId(id) {
       if (id === RUNTIME_CLIENT_RUNTIME_PATH || id === RUNTIME_CLIENT_ENTRY_PATH) {
-        return id
+        return wrapVirtualPrefix(id)
       }
 
       return
     },
     load(id) {
-      if (id === RUNTIME_CLIENT_RUNTIME_PATH) {
+      if (id === wrapVirtualPrefix(RUNTIME_CLIENT_RUNTIME_PATH)) {
         return runtimeCode
       }
 
-      if (id === RUNTIME_CLIENT_ENTRY_PATH) {
+      if (id === wrapVirtualPrefix(RUNTIME_CLIENT_ENTRY_PATH)) {
         return composePreambleCode(devBase, overlayConfig)
       }