v9.0.0 / 2023-09-19 #304
Open
v9.0.0 / 2023-09-19 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornstar
force-pushed
the
support-node-v20
branch
from
6b81abb
to
58c584e
Compare
bjornstar
force-pushed
the
support-node-v20
branch
from
58c584e
to
030064e
Compare
HitkoDev
reviewed
Sep 19, 2023
| const { port1, port2 } = new MessageChannel(); | ||
| port1.on('message', ({ required } = {}) => { | ||
| send({ required }); | ||
| }); |
There was a problem hiding this comment.
Instead of adding process.exit(0) calls in the tests, a better solution would be to just call port1.unref() here (https://nodejs.org/api/worker_threads.html#portunref).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental-specifier-resolutionas it's no longer supporteddevDependencies] Update most devDependencies to their latest version