Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rake-compiler for Ruby 3.2 prebuilt binaries #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnyshields
Copy link

@johnnyshields johnnyshields commented Jan 19, 2023

Please release binaries which support Ruby 3.2 after merging this. It seems in particular x64-mingw-ucrt is not being supported for Ruby 3.2 (it works on Ruby 3.1)

@larskanis
Copy link
Member

I already tried the new RCD version with ffi, but it fails to build libffi for ruby-3.2 on x86-mingw32 like so:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi -I. -I/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/include -Iinclude -I/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src -I. -I/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/include -Iinclude -I/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src -c /home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S  -DDLL_EXPORT -DPIC -o src/x86/.libs/win64.o
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S: Assembler messages:
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:48: Error: unknown pseudo-op: `.seh_proc'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:59: Error: unknown pseudo-op: `.seh_pushreg'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:60: Error: unknown pseudo-op: `.seh_setframe'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:61: Error: unknown pseudo-op: `.seh_endprologue'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:164: Error: unknown pseudo-op: `.seh_endproc'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:177: Error: unknown pseudo-op: `.seh_proc'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:192: Error: unknown pseudo-op: `.seh_endproc'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:198: Error: unknown pseudo-op: `.seh_proc'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:214: Error: unknown pseudo-op: `.seh_stackalloc'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:215: Error: unknown pseudo-op: `.seh_endprologue'
/home/local/COMCARD-NT/kanis/comcard/ffi/ext/ffi_c/libffi/src/x86/win64.S:235: Error: unknown pseudo-op: `.seh_endproc'
make[3]: *** [Makefile:1299: src/x86/win64.lo] Error 1
make[3]: Leaving directory '/home/local/COMCARD-NT/kanis/comcard/ffi/build/x86-mingw32/ffi_c/3.2.0/libffi-i386-mingw32'
make[2]: *** [Makefile:1395: all-recursive] Error 1
make[2]: Leaving directory '/home/local/COMCARD-NT/kanis/comcard/ffi/build/x86-mingw32/ffi_c/3.2.0/libffi-i386-mingw32'
make[1]: *** [Makefile:623: all] Error 2
make[1]: Leaving directory '/home/local/COMCARD-NT/kanis/comcard/ffi/build/x86-mingw32/ffi_c/3.2.0/libffi-i386-mingw32'
make: *** [../../../../ext/ffi_c/libffi.mk:9: "/home/local/COMCARD-NT/kanis/comcard/ffi/build/x86-mingw32/ffi_c/3.2.0/libffi-i386-mingw32"/.libs/libffi_convenience.a] Error 2
rake aborted!

I didn't investigate it deeper though.

@larskanis
Copy link
Member

@johnnyshields
Copy link
Author

Thanks! Should a ticket be filed with libffi?

@larskanis
Copy link
Member

Probably not, given that libffi compiles fine on ruby-3.1 in RCD and ruby-3.2 on native RubyInstaller on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants