prioritize /opt/homebrew/lib (for macos on aarch64 only) for searching path #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzprofessionerd
changed the title
dzprofessionerd
force-pushed
the
ffi-move-ahead
branch
from
e3f2c24
to
c269088
Compare
|
This looks OK, but I think we should understand the problem a little bit better: #880 (comment) |
|
Since #941 is closed, I hope this can be merged soon. |
eregon
reviewed
Jun 29, 2022
| path_candidates = if FFI::Platform::ARCH == 'aarch64' && FFI::Platform.mac? | ||
| ['/opt/homebrew/lib/','/usr/lib/','/usr/local/lib/','/opt/local/lib/'] | ||
| else | ||
| ['/usr/lib/','/usr/local/lib/','/opt/local/lib/','/opt/homebrew/lib/'] |
There was a problem hiding this comment.
Could you remove /opt/homebrew/lib/ from this list? That seems only useful on darwin-arm64.
Also could you add a space after every comma, or even better use %w[path1 path2]?
|
In general it's still unclear if we should prefer /opt/homebrew/lib to /usr/lib (probably not) or /usr/local/lib (maybe, but shouldn't be necessary, and no if that's non-homebrew stuff). I asked on Homebrew/brew#13481 I'm thinking the only safe solution here is to use the existing path, and try every part of it, not just the first directory. |
|
I made a PR for the general fix: #968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.