Add SDK path on macOS #765
Conversation
ext/ffi_c/extconf.rb
Outdated
| @@ -8,7 +8,8 @@ def system_libffi_usable? | |||
| # We need pkg_config or ffi.h | |||
| libffi_ok = pkg_config("libffi") || | |||
| have_header("ffi.h") || | |||
| find_header("ffi.h", "/usr/local/include", "/usr/include/ffi") | |||
| find_header("ffi.h", "/usr/local/include", "/usr/include/ffi") || | |||
| (find_header("ffi.h", `xcrun --sdk macosx --show-sdk-path`.strip) rescue false) | |||
There was a problem hiding this comment.
This needs + /include/ffi, otherwise it doesn't find it: https://github.com/ffi/ffi/pull/765/checks?check_run_id=546591203
rescue false seems brittle to me and might swallow unwanted exceptions.
There was a problem hiding this comment.
I created #766 to show what I was thinking.
There was a problem hiding this comment.
This needs + /include/ffi
Of course! I added "usr/include/ffi" and it seems to work.
To be honest I like this PR (including the rescue) more than #766 . It calls xcrun only when necessary, fits well into the chain, is very simple and doesn't break the installation if anything goes wrong.
There was a problem hiding this comment.
Indeed, I forgot the /usr in front!
As you prefer, I'm thinking just searching /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ffi as in #758 is the simplest now.
I personally dislike any silent rescue, as it can easily become a debugging nightmare.
macOS removed `/usr/include` in recent versions of macOS. This forces the usage of the internal libffi although macOS has a usable one itself. Related to ffi#757
larskanis
force-pushed
the
macos-sdk-paths-v2
branch
from
57e69b2
to
0baed4e
Compare
MacOS removed `/usr/include` in recent versions of macOS. That forced the usage of the internal libffi although macOS has a usable one itself. This commit adds typical paths of the SDK which contain libffi. Since it's possible to use non default SDK paths, there is another fallback to determine the path per "xcrun" command. Fixes ffi#757 Closes ffi#765 Closes ffi#758
macOS removed
/usr/includein recent versions of macOS. This forces the usage of the internal libffi although macOS has a usable one itself.Related to #757 . This is an alternative approach to #758 .