Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for FreeBSD 12 #721

Closed
wants to merge 1 commit into from

Conversation

adam12
Copy link
Contributor

@adam12 adam12 commented Oct 9, 2019

The types for time_t and suseconds_t should be long and not int.

Complementary of 4ba53c5

Related to #544 and #627

The types for time_t and suseconds_t should be long and not int.

Complementary of 4ba53c5

Related to ffi#544 and ffi#627
@larskanis
Copy link
Member

Could you please update ffi to latest changes on master, run rake types_conf and send a pull request for the resulting changes? It should update the types based on system header files for platform x86_64-freebsd12.

@adam12
Copy link
Contributor Author

adam12 commented Oct 10, 2019

Could you please update ffi to latest changes on master, run rake types_conf and send a pull request for the resulting changes? It should update the types based on system header files for platform x86_64-freebsd12.

I had to touch version.rb and force CC to cc to get it to run, but it ended up truncating the types.conf file once it did.

Let me investigate, as this is a much much better solution.

@adam12
Copy link
Contributor Author

adam12 commented Oct 10, 2019

I've opened #722 with the generated types. I had to install and use gcc. I'm not sure if there will be any drawbacks from that.

I did notice a bunch of new types have been added to the list of types. Let me know if there is anything else required.

@larskanis larskanis closed this Oct 28, 2019
@larskanis larskanis reopened this Oct 28, 2019
@larskanis
Copy link
Member

Thanks @adam12 , I merged #722 . I'm curious why clang doesn't work, but I think gcc headers are OK as well.

@larskanis larskanis closed this Nov 11, 2019
@adam12
Copy link
Contributor Author

adam12 commented Nov 11, 2019

Thanks @adam12 , I merged #722 . I'm curious why clang doesn't work, but I think gcc headers are OK as well.

Thanks for merging!

@adam12 adam12 deleted the update-freebsd12-types branch November 11, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants