Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FFI::Platform::CPU from C to Ruby and remove duplicated libtest #663

Merged
merged 2 commits into from Jan 23, 2019
Merged

Move FFI::Platform::CPU from C to Ruby and remove duplicated libtest #663

merged 2 commits into from Jan 23, 2019

Commits on Jan 15, 2019

  1. Move FFI::Platform::CPU from C to Ruby 

    The CPU detection was moved to C 10 years ago as a workaround to an
incorrect RbConfig::CONFIG['host_cpu'] value on MacOS.
This was in commit c53282a .
Although I can't reproduce the original environment, I guess that
this issue has been fixed years ago, so that the workaround isn't
necessary anymore.

Moving CPU detection to Ruby allows to use lib/ffi/platform.rb in
Rakefile before the C ext is built.
    @larskanis
    larskanis committed Jan 15, 2019
    Copy the full SHA
    9e33d52 View commit details
    Browse the repository at this point in the history

  2. Remove libtest from repo and from Rakefile 

    The test library has been moved to spec/ffi/fixtures and it's built
by the spec helper. This was in commit c79e9f5 .

Since that time we managed two copies of these tests, but only the one
in spec/ffi/fixtures is actually used.
    @larskanis
    larskanis committed Jan 15, 2019
    Copy the full SHA
    f3fa58d View commit details
    Browse the repository at this point in the history